Repository navigation
fix(ci): wait for controller reconciliation before Kubernetes conformance - #4676
Conversation
|
@pimlock can you resolve the conflict? Otherwise LGTM |
…ance Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
d37b595 to
a816e30
Compare
|
Label |
TaylorMutch
left a comment
There was a problem hiding this comment.
Reviewed the full diff; no blocking findings. The scheduling-gated probe verifies controller ownership and reconciliation, cleanup runs on success and failure, and readiness failures collect diagnostics before failing conformance. ShellCheck and Bash syntax checks passed for the diagnostic collector. All PR checks completed: 109 passed and 12 skipped, including passing K3s and K3s HA installed-artifact conformance.
Summary
Kubernetes conformance currently starts when the gateway connects, even if Agent Sandbox is still recovering after guest boot. This can fail the first sandbox creation before scenario assertions run. This PR waits for controller reconciliation before starting conformance and collects controller diagnostics when preparation or tests fail.
Related Issue
Closes #4675.
Changes
Testing
be9d7a0561cfd55b1ca426f0217e283a4e28b6b8. The probe waited 10.9 seconds through controller recovery, then cleaned up.Local VM validation used ARM64; the original CI failure used x86-64. The local controller certificate error and recovery do not establish the original failure's exact cause.
Checklist